feat(ui): render preview of correct size in landscape orientation for non-camera sources #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThibaultBee
force-pushed
the
main
branch
3 times, most recently
from
2bae7b3 to
d9672bc
Compare
Owner
|
Got issue with rebase. Anyway, the patch is there: 5260b90 |
dimadesu
added a commit
to dimadesu/LifeStreamer
that referenced
this pull request
Oct 27, 2025
I originally had to make a local copy and tweak to add a fix for custom source preview rotation. After my fix was contributed back to StreamPack ThibaultBee/StreamPack#239 this local copy can be deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes preview aware of display orientation allowing it to correctly display bitmap and other non-camera previewable sources.
Implements Git Issue #238.
In camera demo
PreviewViewis in "fill" mode by default"Fill" Before
Portrait is fine.
In landscape bitmap is wrong size, stretched vertically.
"Fill" After
In portrait nothing changed. Correct.
Landscape shows correct bitmap proportions.
It's more evident in "fit" mode of
PreviewViewPortrait is fine.
In landscape bitmap is wrong size, stretched vertically.
"Fit" After
In portrait nothing changed. Correct.
Landscape now shows correct bitmap proportions.